Usage of checkGLcall in wined3d

Paul Vriens Paul.Vriens at xs4all.nl
Mon Jun 19 14:25:20 CDT 2006


Hi,

while going through some wined3d code I've seen that a 'normal' sequence
is:

<some call>;
checkGLcall("<some call>");

there are however several cases where the call isn't followed by a
checkGLcall:

surface.c:1713:        glEnable(GL_TEXTURE_2D);

surface.c:2165:            glEnable(GL_SCISSOR_TEST);

or that parameters/text are wrong for checkGLcall:

surface.c-2220-            glBindTexture(GL_TEXTURE_2D, 0);
surface.c:2221:            checkGLcall("glEnable glBindTexture");

surface.c-2406-        glGetIntegerv(GL_DRAW_BUFFER, &prev_draw);
surface.c:2407:        vcheckGLcall("glIntegerv");

Should this one be defined as a janitorial task? 

Cheers,

Paul.




More information about the wine-devel mailing list