[AppDB] - make variables more consistent, fix indenting

Chris Morgan cmorgan at alum.wpi.edu
Tue Jun 20 15:21:11 CDT 2006

Would per-directory patches be easier to read?  Like one for /include, one 
for /admin, one for / ?

This patch is a precursor to a patch that will close up a bunch of security 
holes that could result in the db being destroyed, then on to finding a more 
appropriate solution to the makeSafe() patch.


On Tuesday 20 June 2006 4:12 pm, Tony Lambregts wrote:
> Chris Morgan wrote:
> > Make the code more consistent by using the appdb coding standards.
> >
> > Change $result = query_appdb(...) to $hResult = ... etc.
> >
> > Also fix some odd indenting due to spaces vs. tabs.
> >
> > There are still a ton of variables that are integers or strings that
> > should be prefixed with 'i' or 's' if anyone is interested in cleaning
> > some of that up.
> >
> > Chris
> I am not opposed to doing this but I think that the patch is way too big.
> At the momment we still have issues with the last "big patch" that are not
> cleared up [1]. On the whole unless we cannot avoid it I really do not
> think that we should be making such large changes in one go like this.
> Please break up the patch into smaller patches. That way it is easier to
> find and fix any issues that arise.
> [1] New versions end up as orphans with current setup.
> --
> Tony Lambregts

More information about the wine-devel mailing list