wined3d: Bind correct # of samplers for GLSL shaders

Ivan Gyurdiev ivg231 at
Tue Jun 20 17:54:42 CDT 2006

On 6/20/06, Jason Green <jave27 at> wrote:
> - We are only checking against GL_MAX_TEXTURES when binding samplers,
> when we should be checking against the maximum number of samplers that
> the card supports.  Spotted by H. Verbeet.

Yes, I'm aware of was done on purpose.
This limit is in a lot of other places - stateblock code, drawprim code.
Have you checked that it will all interact properly using this higher limit?
Specifically, have you tested a sampler > 4 with SetTexture()?

I think this problem should be solved by a single patch that updates all the
necessary places to use the higher texture units value, as opposed to the
legacy one (there's some caps code to write for this).
-------------- next part --------------
An HTML attachment was scrubbed...

More information about the wine-devel mailing list