COMCTL32: Fix some gcc 4.1 warnings caused by windowsx.h macros.

Mike McCormack mike at
Fri Mar 3 04:16:14 CST 2006

Rob Shearman wrote:

> I see little benefit in this warning being enabled.
> IMHO, it would be better to see one patch that turns this warning off 
> than ten patches that obfuscate the code

Yesterday, Alexandre fixed 4 problems that showed using this warning:;a=commit;h=c9cc7e33ffaaf9b359d6bccf778e34d1b955a517

They showed up with gcc 4.1, but I didn't notice them because of the 
warnings from function casts.  It's probably possible to turn it off 
using -Wno-unused-value, but there are real problems that will be caught 
with it.  Consider part of Alexandre's patch yesterday:

+++ b/dlls/ole32/ole2.c
@@ -801,7 +801,7 @@ static HRESULT WINAPI EnumOLEVERB_Next(
          rgelt->grfAttribs = atolW(pwszAttribs);

          if (pceltFetched)
-            *pceltFetched++;
+            (*pceltFetched)++;
      return hr;

Getting rid of the relative small number of macro uses that cause the 
warning doesn't seem to difficult, or to obfuscate the code too much to me.


More information about the wine-devel mailing list