Feedback request on wininet patch

[Mike McCormack]

Victor Pelt wrote:

> -        FIXME("Option INTERNET_OPTION_RECEIVE_TIMEOUT: STUB\n");
> +      {

It would be nice if you could use indentation consistent with the rest 
of the file, and avoid tabs.

> +	unsigned long conns=*(unsigned long*)lpBuffer;

What's 'conns' for?

> +	/* have HINTERNET hInternet , handle where to set the options */
> +	int result = setsockopt(INET_getSocketHelper(lpwhh), INET_getProtocolHelper(lpwhh), SO_RCVTIMEO, lpBuffer, (int)sizeof(lpBuffer));
> +
> +	if (result == 0) {
> +	  ret = TRUE;
> +        } else {
> +	  /* Translate the result in the right error to return */
> +	  ret = FALSE;
> +        }
> +      }

How about "ret = (result == 0);"?

> @@ -2455,6 +2504,9 @@ BOOL WINAPI InternetSetOptionW(HINTERNET
>      case INTERNET_OPTION_CONNECT_RETRIES:
>          FIXME("Option INTERNET_OPTION_CONNECT_RETRIES: STUB\n");
>          break;
> +    case INTERNET_OPTION_CONTEXT_VALUE:
> +	FIXME("Option INTERNET_OPTION_CONTEXT_VALUE; STUB\n");
> +	break;
>      default:
>          FIXME("Option %ld STUB\n",dwOption);
>          INTERNET_SetLastError(ERROR_INVALID_PARAMETER);

This chunk should be in a separate patch, since it's unrelated.

> +/* Helper functions to get unix backend stuff based in windows handles (LPWININETHANDLEHEADER s) */
> +int INET_getSocketHelper(LPWININETHANDLEHEADER);
> +int INET_getProtocolHelper(LPWININETHANDLEHEADER);

Why not just make these static, and get rid of these declarations?

Mike