GDI32: [1/5] freetype.c add more font selecting&linking mechanism support.

Huw D M Davies h.davies1 at physics.ox.ac.uk
Tue Mar 7 09:01:34 CST 2006


On Tue, Mar 07, 2006 at 11:58:01PM +0900, Byeong-Sik Jeon wrote:
> 2006-03-07 (화), 14:22 +0000, Huw D M Davies 쓰시길:
> > 
> > Why don't you just use "tahoma.ttf" in the code where you call
> > find_face_from_filename, there's no point in initializing a char
> > string like this.
> Yes. will be change to   static const char Tahoma_ttf[] = "tahama.ttf";

Just remove the variable completely and call find_face_from_filenae("tahoma.ff")

> > > -    system_font_link->font_name = strdupW(System);
> > > +    system_font_link->font_name = strdupW(defSystem);
> > 
> > Please don't use defSystem here.  That's supposed to be a fallback for
> > System.  Please leave it as it was.
> I can't understand. defSans, defFixed, defSerif is already using in the WineEngCreateFontInstance().
> this is different case?

The def* strings are supposed to be the default fallback names for the
various fonts.  Here you just want to use the string "System", so
please leave it as it was.

Huw.
-- 
Huw Davies
huw at codeweavers.com



More information about the wine-devel mailing list