advpack [6/17]: NULL-terminate the field string if an option is
provided
Alexandre Julliard
julliard at winehq.org
Fri May 5 14:23:19 CDT 2006
"James Hawkins" <truiken at gmail.com> writes:
> diff --git a/dlls/advpack/install.c b/dlls/advpack/install.c
> index 6432406..93d8012 100644
> --- a/dlls/advpack/install.c
> +++ b/dlls/advpack/install.c
> @@ -101,9 +101,17 @@ static HRESULT run_post_setup_commands_c
> ADVInfo *info = (ADVInfo *)arg;
> INFCONTEXT context;
> HRESULT hr = S_OK;
> + LPWSTR ptr;
> DWORD size;
> + BOOL ok;
>
> - BOOL ok = SetupFindFirstLineW(hinf, field, NULL, &context);
> + if ((ptr = strchrW(field, ':')))
> + {
> + FIXME("Options ignored!\n");
> + *ptr = '\0';
> + }
field is a constant string, you shouldn't write to it (or if it's
really supposed to be writable you need to fix the prototype).
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list