wininet: Fix a possible NULL pointer deference (Coverity)
Alexandre Julliard
julliard at winehq.org
Thu May 11 04:46:14 CDT 2006
Mike McCormack <mike at codeweavers.com> writes:
> diff --git a/dlls/wininet/dialogs.c b/dlls/wininet/dialogs.c
> index 24c8506..f24e4ef 100644
> --- a/dlls/wininet/dialogs.c
> +++ b/dlls/wininet/dialogs.c
> @@ -119,10 +119,9 @@ static BOOL WININET_GetAuthRealm( HINTER
> if( q )
> *q = 0;
> }
> + strcpyW( szBuf, p );
> }
>
> - strcpyW( szBuf, p );
> -
> return TRUE;
> }
Do we really want to return the unmodified string in that case? That
doesn't seem quite right.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list