user32: Add more ShowWindow tests

Dmitry Timoshkov dmitry at
Mon May 15 23:16:00 CDT 2006

"Alexandre Julliard" <julliard at> wrote:

>> @@ -3217,7 +3295,7 @@ static void test_showwindow(void)
>>      trace("calling ShowWindow( SW_SHOWMAXIMIZE ) for invisible popup window\n");
>>      ShowWindow(hwnd, SW_SHOWMAXIMIZED);
>> -    ok_sequence(WmShowMaxPopupResizedSeq, "ShowWindow(SW_SHOWMAXIMIZED):popup", FALSE);
>> +    ok_sequence(WmShowMaxPopupResizedSeq, "ShowWindow(SW_SHOWMAXIMIZED):popup", TRUE);
> It would be better to avoid turning working tests back into todos,
> because it means a lot of things will no longer be properly regression
> tested, since todo applies to the whole sequence.

It would be better, yes, but I don't see how adding new tests could avoid
that if the existing test fail already. I don't see how I can make existing
tests not fail while adding new ones and not touching any real code. I can
resend the patch with omitting the lines in my patch which mark existing
(failing) tests as todo, is that what you need? Certaily I can have a look
why existing tests fail (do they fail for you?), but that has nothing to do
with this my patch.


More information about the wine-devel mailing list