comctl32_tests: Janitorial: write-strings warning fix

Robert Shearman rob at
Sat May 27 17:29:55 CDT 2006

Andrew Talbot wrote:

>Because I have had at least one patch like this accepted, I assumed what I
>was doing was OK. I guess another way of preventing this warning would be
>to use:
>    x.pszText = (LPSTR) "string";
>Assuming there is no danger in using this method, then it is neater for a
>single assignment. The array method may be better when the same text is
>assigned several times in the same function or file.

This method should be safe for this particular instance.

>If what I am doing is incorrect or not helpful, I would welcome advice to
>that effect. After all, I'm trying to make myself useful, not mess things

Absolutely. We should avoid regressions at all costs, but making literal 
strings non-writable should help to uncover bugs.

Rob Shearman

More information about the wine-devel mailing list