user32: Factorize graphics driver's WindowCreate and ShowWindow in user32.

Dmitry Timoshkov dmitry at codeweavers.com
Wed Nov 29 22:34:41 CST 2006


"Pierre d'Herbemont" <pdherbemont at free.fr> wrote:

> At the same time ShowWindow gets factorized because WindowCreate and 
> ShowWindow share both the use of WINPOS_MinMaximize, so it is easier to 
> factorize both functions in a single patch. In fact ShowWindow is 
> removed entirely from the drivers as it is driver independant.
> 
> To properly factorize WindowCreate we have to export 3 new functions 
> from the graphics driver which are SetIconicState, SyncWindowStyle, 
> SystrayDockWindow.

I'd suggest to leave ShowWindow in the driver's interface. You already
have created 3 new entry points to replace its partial functionality,
but still miss ShowWindow functionality for at least SW_RESTORE and
SW_MAXIMIZE. Also did you run 'make test' after this patch?

-- 
Dmitry.



More information about the wine-devel mailing list