[PATCH 1/3] lz32/tests: Test more last errors set by LZOpenFile[AW].

Saulius Krasuckas saulius2 at ar.fi.lt
Tue Oct 3 12:40:33 CDT 2006

Hello, Dmitry,

* On Wed, 27 Sep 2006, Dmitry Timoshkov wrote:
> * "Saulius Krasuckas" <saulius.krasuckas at ieee.org> wrote:
> >    memset(&filled_0xA5, 0xA5, OFS_MAXPATHNAME);
> >    memset(&test, 0xA5, sizeof(test));
> >    full_file_path_name_in_a_CWD(filename_, expected, FALSE);
> > +  SetLastError(0xfaceabee);
> Please use a usual value we all agreed to use: 0xdeadbeef.

I remember only countless proposals by you to agree on it, but no any 
documented place marking such agreement.  If that's of such an important 
matter, why still no one has added some janitorial page about it? (in the 
wiki for example)

> It makes sense to check last error value only if an API has failed, 
> while you are adding last error checks everywhere. Unless you have an 
> application that depends on it, that's wrong.

Well, thanks.  I'll change that, but is it wrong just because it slightly 
increases code complexity for no direct benefit?  I just want to know for 

More information about the wine-devel mailing list