[PATCH 1/3] Compile oleaut32 for win32 but not for win64
James Hawkins
truiken at gmail.com
Tue Oct 3 17:25:38 CDT 2006
On 10/3/06, Pavel Roskin <proski at gnu.org> wrote:
> On Tue, 2006-10-03 at 14:46 -0700, James Hawkins wrote:
> > > I understand oleaut32 can be fixed for win64, but nobody has done it.
> > >
> > > I believe my patch is worth applying because it enables Wine compilation
> > > without applying incorrect hacks to the sources. Instead, a mechanism
> > > is established to disable some parts of Wine for win64 until they are
> > > ported properly. We may need it for other files.
> > >
> >
> > Removing oleaut32 from the build just hides the real problem, and
> > creates a slew of new problems. What will happen when an app tries to
> > use oleaut32 with a win64 build of Wine? The correct solution is to
> > fix oleaut32 to work with win64, no matter how difficult it is. We
> > can't allow temporary hacks in the meantime, or there will be
> > significantly less motivation to fix the real problem, because a
> > workaround is available.
>
> I'm not going to stop working on other projects and spend days learning
> OLE to fix oleaut32.
>
Ok, then either someone else will step up and fix it, or it will
remain unfixed. Either way, oleaut32 should remain in the win64
build.
>
> I'm not a regular Wine developer, and the above is just a little more
> than "my two cents". Let's not start a flamewar over this, OK?
>
Of course not, that would be silly. I, for one, hope you continue to
submit patches and become a regular Wine developer. We can use the
help. One thing you have to learn though is that the developers
provide a lot of constructive criticism in order to keep Wine at a
professional level, and you shouldn't take offense to it. It's all a
part of the process.
--
James Hawkins
More information about the wine-devel
mailing list