[WINED3D 1/6] Move D3DSIO structure into the WINED3D namespace.
ivg231 at gmail.com
Wed Oct 4 21:19:49 CDT 2006
Alexandre Julliard wrote:
> Ivan Gyurdiev <ivg231 at gmail.com> writes:
>> Note: A new file was started for this purpose: wined3d_types.h. This
>> is _not_ the same as the one in the wine include folder - that one
>> should be for types which appear in the interface of wined3d, and must
>> therefore be exposed to other dlls. This one is private. I think the
>> dll interface should be strictly enforced, so private structures have
>> no place outside our folder.
> This will cause massive confusion. There is already a
> wined3d_private.h file, you should put that stuff in there.
The amount of structures added will quickly result in an unmaintainable
header. There's a very clear difference between the two -
wined3d_types.h would be for types equivalent to the d3d types -
essentially no maintainance, simply map one-to-one to d3d.
wined3d_private.h would be for shared structures that we come up with.
Also, wined3d_private.h includes wined3d_types.h.
I will comply if you want it this way, but I disagree - smaller files
are easier to work with.
In fact, I think having a single private header per dll is probably a
mistake as well.
More information about the wine-devel