Force a Display/Input-Driver? (Re: [PATCH 2/5] dinput: Use x11_[acquire|unacquire]_mouse to stop mouse from escaping in exclusive mode.)

Detlef Riekenberg at
Thu Oct 5 14:59:17 CDT 2006

On Do, 2006-10-05 at 08:09 -0600, Vitaliy Margolen wrote:
> diff --git a/dlls/dinput/dinput_main.c b/dlls/dinput/dinput_main.c

> +        if ((mod = GetModuleHandleA( "winex11.drv" ))) 

When we force wine to use a specific Display/Input-Driver, the
driver-selection by reading the Registry is unneeded and should
be removed.

IMHO, the clean way is to use the dynamic Driver Name, build from
the Registry
(preferable by a common used wine specific Function in a dll).

> + = (void*) GetProcAddress(mod, "wine_tsx11_acquire_mouse");

The exported name is also not generic.

And we have both issues already:

$ grep -i --line-number "winex11.drv" dlls/*/*
 x11drv = GetModuleHandleA("winex11.drv");

  HMODULE mod = GetModuleHandleA( "winex11.drv" );

  mod = GetModuleHandleA( "winex11.drv" );

 hx11drv = GetModuleHandleA("winex11.drv");

Exported Name:
...  = (void *)GetProcAddress( mod, "wine_tsx11_lock" );

By by ... Detlef

More information about the wine-devel mailing list