[PATCH 1/5] lz32/tests: Test more last errors set by LZOpenFile[AW].

Alexandre Julliard julliard at winehq.org
Fri Oct 6 11:28:42 CDT 2006

Saulius Krasuckas <saulius2 at ar.fi.lt> writes:

> Unless Alexandre confirms the requirement directly.  In such case I am 
> going to put this stuff into our Wiki ^^ even write a patch for cleaning 
> the calls myself ;)

There's no need to enforce 0xdeadbeef, other similar magic values work
just as well.

> That was the reason I kept the check in.  It doesn't enforce unnecessary 
> complexity in the function, so I doubt the check is wrong.  Especially 
> given that this fn on both platforms behaves *quite* differently while 
> operating on compressed file(name)s.

Testing last error on success is not useful. It will only cause
spurious test failures, so it should be done only if the API specifies
a certain behavior, or if you have a real app that depends on it.

Alexandre Julliard
julliard at winehq.org

More information about the wine-devel mailing list