user: add GetRawInputDeviceList stub

Vitaliy Margolen wine-devel at kievinfo.com
Sat Oct 14 10:04:26 CDT 2006


L. Rahyen wrote:
> Add missing stub to user32.dll.so - without it some games (like Postal 2 and 
> some others) cannot run. It seems that GetRawInputDeviceList is useless thing 
> in most cases because all these games works almost perfectly with this stub.
> 
Thank you for sending patch. Here are few problems with it you need to fix:

> +/****************************************************************************
> + *              GetRawInputDeviceList (USER32.@)
> + */
> +typedef struct tagRAWINPUTDEVICELIST {
> +    HANDLE hDevice;
> +    DWORD dwType;
> +} RAWINPUTDEVICELIST, *PRAWINPUTDEVICELIST;
All the definitions should go into headers. This particular one should
go into winuser.h

> +
> +UINT WINAPI GetRawInputDeviceList(PRAWINPUTDEVICELIST pRawInputDeviceList, 
> PUINT puiNumDevices, UINT cbSize)
This line is wrapped.

> +{
> +    FIXME("user: GetRawInputDeviceList stub");
No need to include function name, it will already be printed by FIXME.
Also you missing newline. So this should be something like: FIXME("stub\n");

> +    return NULL;
> +}
Return type is UINT not pointer. You should return 0. But you also need
to set *puiNumDevices to 0.

> 
>  /******************************************************************
>   *              GetLastInputInfo (USER32.@)
> --- dlls/user/user32.spec       2006-10-02 18:06:21.000000000 +0000
> +++ dlls/user/user32.spec~      2006-10-02 18:09:01.000000000 +0000
> @@ -304,6 +304,7 @@
>  @ stdcall GetKeyboardType(long)
>  @ stdcall GetLastActivePopup(long)
>  @ stdcall GetLastInputInfo(ptr)
> +@ stdcall GetRawInputDeviceList(ptr long long)
There is already that entry in the spec file. Please search it and
replace. Don't add duplicate.

Vitaliy



More information about the wine-devel mailing list