winetest: don't start test programs with STARTUPINFO.wShowWindow = SW_HIDE

Dmitry Timoshkov dmitry at codeweavers.com
Sat Oct 14 23:18:19 CDT 2006


"Francois Gouget" <fgouget at free.fr> wrote:

> On Sat, 14 Oct 2006, Mikoaj Zalewski wrote:
> 
>> It no one knowns why this option is there then maybe it's safe to remove it?
> -    si.wShowWindow = SW_HIDE;
> -    si.dwFlags = STARTF_USESHOWWINDOW;
> +    si.dwFlags = 0;
> 
> Isn't this an attempt to make it so that running make test does not pop 
> up windows that grab the focus and do things that prevent you from using 
> the computer?

The patch should be applied IMO. That SW_HIDE thing must be the cause
why user32 tests fail without a visible reason when running by winetest,
the tests must be run on a visible desktop anyway.

-- 
Dmitry.



More information about the wine-devel mailing list