[secur32] Remove test that crashes on Win2k
James Hawkins
truiken at gmail.com
Tue Oct 31 01:58:30 CST 2006
On 10/30/06, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
> On Mon, 2006-10-30 at 23:44 -0800, James Hawkins wrote:
> > On 10/30/06, Paul Vriens <paul.vriens.wine at gmail.com> wrote:
> > > Hi,
> > >
> > > makes sure the other tests are run.
> > >
> > > Changelog
> > > Remove test that crashes on Win2k
> > >
> > > Cheers,
> > >
> > > Paul.
> > >
> > > ---
> > > dlls/secur32/tests/schannel.c | 2 ++
> > > 1 files changed, 2 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/dlls/secur32/tests/schannel.c b/dlls/secur32/tests/schannel.c
> > > index 23e2a0a..95669fe 100644
> > > --- a/dlls/secur32/tests/schannel.c
> > > +++ b/dlls/secur32/tests/schannel.c
> > > @@ -140,10 +140,12 @@ static void testAcquireSecurityContext(v
> > > NULL);
> > > ok(st == SEC_E_SECPKG_NOT_FOUND,
> > > "Expected SEC_E_SECPKG_NOT_FOUND, got %08x\n", st);
> > > + /* Crashes on Win2K
> > > st = pAcquireCredentialsHandleA(NULL, unisp_name_a, 0, NULL, NULL, NULL,
> > > NULL, NULL, NULL);
> > > ok(st == SEC_E_NO_CREDENTIALS, "Expected SEC_E_NO_CREDENTIALS, got %08x\n",
> > > st);
> > > + */
> >
> > Please use #if 0/#endif to comment out pieces of code.
> >
> Hi James,
>
> there is a commented out test a few lines below. I thought I'd stick to
> how it's done in this file.
>
In this case, it's not really a 'style' issue, where we keep the style
the same in the file. We shouldn't be using actual comments to
disable code. If you want to change the other case to #if 0, I
wouldn't have a problem with that, but we shouldn't be adding more
comments
--
James Hawkins
More information about the wine-devel
mailing list