Fix xcopy so output is either unicode (console) or oem (file)

Kirill K. Smirnov lich at math.spbu.ru
Sat Apr 21 04:24:32 CDT 2007


> I've just found another bug in the patch:
> >+      /* Convert to OEM, then output */
> >+      convertedChars = WideCharToMultiByte(GetConsoleOutputCP(), 0,
> >output_bufW,
> >+                          len, output_bufA, MAX_WRITECONSOLE_SIZE,
> >+                          "?", &usedDefaultChar);
>
> The comment is correct, but code is wrong. Here should be CP_OEMCP instead
> of GetConsoleOutputCP().

Please, ignore it. The patch is correct.



More information about the wine-devel mailing list