include: introduce ntsecpkg.h
kai.blin at gmail.com
Sat Apr 21 04:31:51 CDT 2007
On Saturday 21 April 2007 00:20, Yuval Fledel wrote:
> ntsecpkg.h specifies the interface with Authentication Security
> Support Providers.
This is a quick glance over your file, comparing with the implementation I had
lying around on my box.
> The first 50 lines were imported from w32api. The rest was submitted
> to w32api too.
The ISC_* and ASC_* #defines are useless. You include security.h, which in
turn includes sspi.h which contains all of those.
SECURITY_NATIVE_DREP and SECURITY_NETWORK_DREP are defined in rpc.h, no need
to have them in ntsecpkg.h
Looking at other include files, I don't think
+#if __GNUC__ >=3
+#pragma GCC system_header
should be in there.
> I wish I could make the patch smaller, however the last two lines
> depend on all the rest, and the rest is useless without the last two.
You could make the patch mor readable by adding the occasional new line
between the typedefs of all those structs.
Looking good otherwise.
Kai Blin, <kai Dot blin At gmail Dot com>
WorldForge developer http://www.worldforge.org/
Wine developer http://wiki.winehq.org/KaiBlin/
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Size: 189 bytes
Desc: not available
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20070421/51613868/attachment.pgp
More information about the wine-devel