[Try 3] [programs/uninstaller] Check HKCU for uninstall entries

James Hawkins truiken at gmail.com
Tue Apr 24 15:56:03 CDT 2007

On 4/24/07, Tom Spear <speeddymon at gmail.com> wrote:
> This patch makes the wine uninstaller check HKCU for uninstall entries
> in addition to HKLM.

+const int numrootkeys = 2;
+static const DWORD maxSubkeyNameLen = 255;

const variables should be all uppercase to differentiate them from
non-const variables.  One of the const variables is static and the
other not, what gives?

@@ -148,7 +149,6 @@
                 WINE_ERR( "The remove option requires a parameter.\n");
                 return 1;
             RemoveSpecificProgram( argv[i++] );

Don't make random whitespace changes.

+    for (x=0; x<sizeof(hkeyroot[0]); ++x)
+    {

sizeof(hkeyroot[0]) = 4, which means you're going to index hkeyroot
two indexes out of bounds.  I think you're looking for
sizeof(hkeyroot) / sizeof(hkeyroot[0]).

+		WINE_TRACE("allocated entry #%d: %s (%s), %s\n",
+                numentries, wine_dbgstr_w(entries[numentries-1].key),

You mixed tabs and spaces, and that line is too long.

James Hawkins

More information about the wine-devel mailing list