[3/20] WineD3D: Implement IWineD3DDeviceImpl_CreateVertexDeclarationFromFVF

Ivan Gyurdiev ivg231 at gmail.com
Wed Apr 25 00:55:09 CDT 2007


 > Stefan Dösinger wrote:

You're returning a size_t here, which does not match the 
WINED3DERR_OUTOFVIDEOMEMORY returned on the HeapAlloc (granted, that's 
probably incorrect behavior by d3d9, but at least the return types 
should be consistent).

Does that mean we'll be removing the other two versions of this code in 
existence (d3d9, and drawprim conv)? By the way, who wrote the very 
first version - I was looking through git history to figure out the 
proper copyright attribution, and it predates the git tree. I guess we 
should update the copyright in d3d9/vertexdeclaration.c to list that 
person if it isn't done already. I was just curious...

Ivan





More information about the wine-devel mailing list