gdi32: don't print fixme more than once

Robert Shearman rob at codeweavers.com
Fri Aug 3 17:01:39 CDT 2007


Evan Stade wrote:
> diff --git a/dlls/gdi32/enhmetafile.c b/dlls/gdi32/enhmetafile.c
> index 9e7684b..2b4d03f 100644
> --- a/dlls/gdi32/enhmetafile.c
> +++ b/dlls/gdi32/enhmetafile.c
> @@ -1172,6 +1172,7 @@ BOOL WINAPI PlayEnhMetaFileRecord(
>  
>      case EMR_EXTSELECTCLIPRGN:
>        {
> +        static int extselectcliprgn_cases;
>  #if 0
>  	const EMREXTSELECTCLIPRGN lpRgn = (const EMREXTSELECTCLIPRGN *)mr;
>  	HRGN hRgn = ExtCreateRegion(NULL, lpRgn->cbRgnData, (RGNDATA *)lpRgn->RgnData);
> @@ -1180,7 +1181,8 @@ #if 0
>  	/* ExtSelectClipRgn created a copy of the region */
>  	DeleteObject(hRgn);
>  #endif
> -        FIXME("ExtSelectClipRgn\n");
> +        if(!(extselectcliprgn_cases++))
> +            FIXME("ExtSelectClipRgn\n");
>          break;
>        }
>   

It would be better to re-enable this code, remove the fixme and fix 
whatever bug caused it to be disabled in the first place than to not 
show the fixme as often.

-- 
Rob Shearman




More information about the wine-devel mailing list