[Winetest] Possible removal of LoadLibrary and friends in the
conformance tests
Paul Vriens
paul.vriens.wine at gmail.com
Tue Aug 7 02:43:13 CDT 2007
Hi,
With the current version of winetest, conformance tests for which the main dll
is not available will not run anymore. This will be reported on test.winehq.org.
We will be seeing the new approach as of 12:00 GMT when the new winetest.exe is
available and the first tests come in.
Several tests currently check for the existence of the dll via LoadLibrary and
do a lot of GetProcAddress calls to retrieve function pointers.
This should not be needed anymore in most cases. The tests that come to mind:
d3d8
d3d9
d3drm
gdiplus
localspl
localui
pdh
uxtheme
and there are (and will be in the future) others.
My plan, and this is open for discussion of course, is to:
1. Add the main dll back as part of the IMPORTS in the Makefile.in files
2. Change LoadLibrary to GetModuleHandle and still use GetProcAddress to catch
unexported functions (for a short period). We do need to reporting missing
functions.
3. Remove GetModuleHandle and/or GetProcAddress's if possible and make more use
of 'skip' if needed.
This will be a lengthy process so if there are volunteers, please step up.
Eventhough this is some considerable amount of work to be done, in the end the
code will be cleaner (and several lines shorter).
Comments/remarks ?
Cheers,
Paul.
More information about the wine-devel
mailing list