winex11drv: Treat CapsLock and NumLock keys as normal keys. They should toggle on button down.

Alexandre Julliard julliard at winehq.org
Tue Dec 11 03:44:38 CST 2007


Vitaliy Margolen <wine-devel at kievinfo.com> writes:

> Alexandre Julliard wrote:
>> Vitaliy Margolen <wine-patches at kievinfo.com> writes:
>> 
>>> On winxp both keys toggle on button down not button up. So no need for any extra treatment.
>>> Fixes bug 10446.
>> 
>> You still have to handle the case when the state has been toggled
>> outside of Wine, you can't just get rid of the whole thing.
>> 
> And how's the current code handles that? By setting few internal thread 
> unsafe constantly being reset flags?

No, it does this by simulating a keypress if the state has been changed
outside Wine, nothing to do with the global flags. I certainly agree the
global flags can be removed, but that doesn't mean you can remove the
rest of the code without understanding what it does.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list