[PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

Vitaliy Margolen wine-devel at kievinfo.com
Fri Dec 14 15:07:59 CST 2007


First of all your patch is wrapped. Second, do not send white space changes 
only. Same for formatting - do not change formatting only. If you can't read 
it, reformat for yourself, or get used to reading some one else's code.

What's wrong with gotos? If you don't like it doesn't mean everyone else 
can't use them. Don't change that part. Copying 10 lines of code into 10 
places doesn't justify removing 10 lines of code.

You should probably check the patch requirements: 
http://winehq.org/site/sending_patches

Vitaliy.

Adam Rimon wrote:
> ---
> 
>  dlls/dinput/mouse.c |  415 
> +++++++++++++++++++++++++++++----------------------
>  1 files changed, 235 insertions(+), 180 deletions(-)
> 




More information about the wine-devel mailing list