[PATCH] dinput: mouse.c: extracted the warping code into a function, got rid from goto's in alloc_device, and made the code more readable. (no change in functionality)

Kai Blin kai.blin at gmail.com
Sat Dec 15 03:35:17 CST 2007

On Saturday 15 December 2007 10:01:44 Adam Rimon wrote:
> Yeah, I read it. Can you explain to me the logic behind this decision
> (In general, not about this specific code)?

You mess up the output of e.g. git blame without ever changing the 
functionality of the code.

> I think formatting a code is an important thing to do.

Yes, but it needs to be done initially, or when the code is touched, not for 
it's own sake.

> It makes the code easier to understand for programmers who have never
> seen the code before,

If they want to read the code the way you think it should be read.

> and makes it also more maintainable.


> In this code, for example, the white spaces and tabs are mixed, the
> curly braces are sometimes right next to the line before
> and sometimes in the next line, etc.

I think there's no argument about the less than optimal formatting of the code 
you're talking about. Nevertheless, we're just telling you that it's very 
unlikely that this patch will be rejected.

Alexandre doesn't like patches like that, you'll have to fork or deal with it. 
People on this list decided to deal with it, so don't be surprised if that's 
the answer you get again and again.


Kai Blin
WorldForge developer  http://www.worldforge.org/
Wine developer        http://wiki.winehq.org/KaiBlin
Samba team member     http://www.samba.org/samba/team/
Will code for cotton.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 189 bytes
Desc: This is a digitally signed message part.
Url : http://www.winehq.org/pipermail/wine-devel/attachments/20071215/5dbea26b/attachment.pgp 

More information about the wine-devel mailing list