comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicode

Alexander Nicolaysen Sørnes alex at thehandofagony.com
Mon Dec 31 09:08:16 CST 2007


On Monday 31 December 2007 07:39:28 Dmitry Timoshkov wrote:
> "Alexander Nicolaysen Sørnes" <alex at thehandofagony.com> wrote:
> > comdlg32: 1/2 PageSetupDlg: Convert paint procs to Unicod
>
> What's the purpose of this patch? It improves nothing IMO except of
> making the code less readable, making it not thread safe, calling
> CallWindowProcW where it shouldn't.


I made these changes so that the PageSetupDlgA/W could share the paper preview 
code, which the W variant currently doesn't have (preview added in patch 
2/2).

I would be grateful if you could suggest ways to improve the code, but if it's 
completely hopeless I'll accept that. :)


Alexander N. Sørnes



More information about the wine-devel mailing list