advapi32: sign-compare fixes
Joris Huizer
joris_huizer at yahoo.com
Wed Feb 7 12:38:57 CST 2007
Vitaliy Margolen <wine-devel at kievinfo.com> wrote: Joris Huizer wrote:
> - int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName,
> + unsigned int len = WideCharToMultiByte(CP_ACP, 0, lpNameW, -1, lpName,
This isn't right. WideCharToMultiByte returns INT, which is signed.
> @@ -1995,11 +1995,11 @@ LookupAccountSidW(
>
> if (dm) {
> BOOL status = TRUE;
> - if (*accountSize > lstrlenW(ac)) {
> + if (*accountSize > (unsigned)lstrlenW(ac)) {
> if (account)
> lstrcpyW(account, ac);
> }
> - if (*domainSize > lstrlenW(dm)) {
> + if (*domainSize > (unsigned)lstrlenW(dm)) {
> if (domain)
> lstrcpyW(domain, dm);
> }
This isn't correct either. lstrlenW() also returns INT and you
can't just cast it to (unsigned). Unsigned what? int/long/dword?
Vitaliy.
Sorry I'll fix it; Will try and check in future
Joris
---------------------------------
Now that's room service! Choose from over 150,000 hotels
in 45,000 destinations on Yahoo! Travel to find your fit.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://www.winehq.org/pipermail/wine-devel/attachments/20070207/41dced37/attachment.html
More information about the wine-devel
mailing list