ole32: Remove casts

Robert Shearman rob at codeweavers.com
Thu Feb 8 01:45:45 CST 2007


Mike McCormack wrote:
> ---
> This is the way ref counting is done everywhere else in Wine.
>
> Ref counts can be assumed to be between 0 and MAXLONG, so the fact 
> that LONG is signed isn't important.

NO. The DCOM spec says that STDOBJREF::cPublicRefs is unsigned, 
therefore the ref counts can be assumed to be up to MAXULONG. Therefore, 
this change is incorrect and it would lead to subtle signedness errors.

>
> Casting ULONG* to LONG* to solve the above problem is unnecessary.
>


-- 
Rob Shearman




More information about the wine-devel mailing list