winealsa commit d2f29311caa8041bd992a3867d71d6311c7ff8fa
Marcus Meissner
marcus at jet.franken.de
Thu Feb 8 13:11:33 CST 2007
Hi Marten,
Your commit:
http://source.winehq.org/git/wine.git/?a=commit;h=d2f29311caa8041bd992a3867d71d6311c7ff8fa
Has some regressions on Coverity.
Namely Coverity complains that "areas" is used uninitializied.
And yes it is:
static DWORD CALLBACK DBSB_MMAPLoop(LPVOID data)
{
IDsDriverBufferImpl* pdbi = (IDsDriverBufferImpl*)data;
WINE_WAVEDEV *wwo = &(WOutDev[pdbi->drv->wDevID]);
snd_pcm_uframes_t frames, wanted, ofs;
const snd_pcm_channel_area_t *areas;
int state = WINE_WS_STOPPED;
snd_pcm_state_t alsastate;
TRACE_(waveloop)("0x%8p\n", data);
TRACE("0x%8p, framelength: %lu, area: %8p\n", data, pdbi->mmap_buflen_frames, pdbi->mmap_areas);
if (areas != pdbi->mmap_areas || areas->addr != pdbi->mmap_areas->addr)
FIXME("Can't access sound driver's buffer directly.\n");
Please fix :)
Ciao, Marcus
More information about the wine-devel
mailing list