dbghelp: Match the crc for debug link files in elf_locate_debug_link so that we get the correct debug file before trying to parse it.

[Eric Pouech]

Robert Shearman a écrit :
> Eric Pouech wrote:
>> Robert Shearman a écrit :
>>>
>>> Keep the debuglink elf_file_map mapped until after 
>>> elf_new_public_symbols is called, otherwise we could use unmapped 
>>> memory.
>>
>> this is still not the full valid solution... what should be done is: 
>> when we search for a given section, we should look first in the 
>> original .so, then, if not found, in the .gnu_debuglink one...
>> your patch only covers the case where all relevant information is to 
>> be found in the .gnu_debuglink file, which is not guaranteed
>
> And that should be easier for an interested person to do after this 
> patch is applied, right? I was just interested in getting rid of bogus 
> crc errors when using winedbg.
>
first, it's not exactly what your patch is entirely about... your patch 
ensures that the newly .gnu_debuglink mapped file is present for symbols 
resolution... and the bogus CRC errors come from the fact that we have 
an ERR for that, were it should be a WARN... a user could have different 
versions of the debug info files
secondly, the correct fix will require a rewrite of the mapping 
algorithm itself, which is rather orthogonal to what you did
my reco would simply to downgrade the ERR to a WARN if you don't want to 
go into the full fix
A+