[PATCH 2/3] server: Fix get_handle for global handles. It doesn't need process for them.

Vitaliy Margolen wine-devel at kievinfo.com
Tue Feb 20 22:47:57 CST 2007


Alexandre Julliard wrote:
> Vitaliy Margolen <wine-devel at kievinfo.com> writes:
> 
>> http://source.winehq.org/source/server/handle.c#L523 calls
>> duplicate_handle with NULL process.
> 
> Yes, but duplicate_handle has no reason to call get_handle on the dst
Sure there is. How else do I set the requested access mask?

> process. I see that your 3/3 patch does this, but that's broken.
Right that's the way it's designed by the original!

I tried to explain the reason by I guess all that and tests are not
enough. If you have a better solution, please implement it by all means.

I have other things to worry about ATM.

Vitaliy.




More information about the wine-devel mailing list