msi: Expand OLE automation interface parameter handling.

James Hawkins truiken at
Wed Feb 28 00:55:07 CST 2007

On 2/27/07, Misha Koshelev <mk144210 at> wrote:
> This applies on top of my other OLE automation patches. Added new
> checks:

Why don't you wait until the other patches are committed before
sending these new patches?  It makes it hard to review, because I
don't have your other patches applied.

> - Parameter we are looking for is not passed?
> - Only set puArgErr if it is passed
> - Make sure pVarResult is valid before we write to it
> - Don't return S_FAIL. MSDN doesn't mention it in the Invoke help, so we
> won't use it.

You need to add tests for these items.

James Hawkins

More information about the wine-devel mailing list