dlls/opengl32/wgl.c: minor dealloc fix
wine-devel at kievinfo.com
Mon Jan 1 19:00:44 CST 2007
DO NOT top post bottom posted emails!!!
Nick Burns wrote:
>> From: Stefan Dösinger <stefandoesinger at gmx.at>
>> To: wine-devel at winehq.org
>> CC: Nick Burns <adger44 at hotmail.com>
>> Subject: Re: dlls/opengl32/wgl.c: minor dealloc fix
>> Date: Mon, 1 Jan 2007 22:33:49 +0100
>> Am 01.01.2007 um 11:03 schrieb Nick Burns:
>>> There can be a problem where the detach is hit before
>>> internal_gl_extensions is allocated and it tries to free NULL and
>>> This just checks for the allocation before freeing -- very minor
>>> - Nick
>> HeapFree(GetProcessHeap(), 0, NULL) is supposed to be a nop, so the
>> check is not needed.
> According to...
> [in] ...If this pointer is NULL, the behavior is undefined.
That's incorrect. 90% of MSDN is not correct or incomplete. The behavior
is well known and defined (at least in Wine) - NULL pointers are ignored.
So your patch is not correct.
More information about the wine-devel