[PATCH] StgOpenStorage patch
Mike McCormack
mike at codeweavers.com
Mon Jan 1 21:22:53 CST 2007
> This is the first time I've submitted a patch, so let me know if this
> method of submission is incorrect. See description in the attachment.
It's best to put the description in the body of the mail, and write a
descriptive subject like "ole32: fix StgOpenStorage conformance test
failure" or something like that.
> This patch stops StgOpenStorage from creating a file when it does not
> already exist. According to Microsoft's description, StgOpenStorage opens
> an _existing_ root storage object... To create a new file, use the
> StorageCreateStorageEx function.
>
> This fixes a bug in Orcad Capture (http://bugs.winehq.org/show_bug.cgi?id=7025)
>
> The conformance test file has also been modified to pass this test (before it
> it was passing in Wine and failing in Windows).
Your patch makes the conformance tests pass on Windows 2000 for me. The
failing test was added some time ago:
http://www.winehq.org/pipermail/wine-patches/2006-September/030808.html
Maybe Andrey could comment on which version of Windows he was using?
Mike
More information about the wine-devel
mailing list