[2/8] WineD3D: Catch NOP vertex declaration changes

H. Verbeet hverbeet at gmail.com
Thu Jan 4 12:33:04 CST 2007


On 04/01/07, Christoph Bumiller <e0425955 at stud3.tuwien.ac.at> wrote:
> Not performing the following:
>
>     if (NULL != pDecl) {
>         IWineD3DVertexDeclaration_AddRef(pDecl);
>     }
>
> in IWineD3DDeviceImpl_SetVertexDeclaration(...) when state is being
> recorded (note the return that was added), seems to cause a page fault,
> at least in NFS: Most Wanted. Is it possible that not adding a
> reference here causes the declaration object to be deallocated to
> early, when it is still used by the application ?
>
Yeah, that'll break refcounts.



More information about the wine-devel mailing list