[PATCH] x11drv: Allow to disable focus to desktop window after last wine window looses focus.

Vitaliy Margolen wine-devel at kievinfo.com
Sat Jul 28 09:28:40 CDT 2007


Tomas Carnecky wrote:
> This patch introduces a new registry key, "FocusDesktopWindow", that can 
> be used to specify whether wine should set the foreground window to the 
> desktop window after the last wine app looses focus. The default is 
> enabled (the same behavior as now).
 
This is a bad hack. The reason I *fixed* the focus lose so Wine can grab pointer
inside it's window and release it when the focus is lost. With what you proposing,
it will be impossible. Then I'd like to see what would you say when Wine will not
be releasing the mouse when you switch away from app?

Also I don't know how many apps did you really test, but lots and lots of apps
can't get the focus because they think they never lost it. Which IMHO is the
reason for most bugs where input goes into terminal not Wine.

> For example World of Warcraft stops sound if it finds out it lost focus and
> there's currently a bug in wine that makes WoW unaware that it regained focus,
> which effectively disables sound.
Then you should fix this bug and not create hacks.


Vitaliy



More information about the wine-devel mailing list