Added GDI+ public headers, small implementation of pen, memory and initialization, and two tests (2nd try)

Alexandre Julliard julliard at winehq.org
Fri Jun 1 02:56:48 CDT 2007


"Evan Stade" <estade at gmail.com> writes:

> I made the fixes that Dmitry suggested.  Additionally I changed the
> public header files to all lower-case (to match the wine headers
> rather than platform sdk headers).  I also consolidated a couple of
> source files so there wouldn't be files with only 2 functions in them.

That's good, please do the same with the init test, there's no reason
to have a separate file for that.

> I believe there was a question earlier on the list about why there is
> "#ifndef __cplusplus ... #endif" around portions of the headers.  This
> is because this implementation of gdi+ only supports c and not c++.

That's not OK, the implementation clearly has to support C++ too, even
if it is written in C.

You should also send that stuff in smaller chunks.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list