winebrowser: Add DDE support and use DDE by default for shell/open.

Misha Koshelev mk144210 at bcm.edu
Mon Jun 4 00:43:16 CDT 2007


On Mon, 2007-06-04 at 14:29 +0900, Dmitry Timoshkov wrote:
> "Misha Koshelev" <mk144210 at bcm.edu> wrote:
> 
> > --- a/tools/wine.inf
> > +++ b/tools/wine.inf
> > @@ -134,8 +134,14 @@ HKCR,txtfile\shell\open\command,,2,"%11%\notepad.exe %1"
> > HKCR,txtfile\shell\print\command,,2,"%11%\notepad.exe /p %1"
> > HKCR,wrifile\shell\open\command,,2,"%11%\wordpad.exe %1"
> > HKCR,wrifile\shell\print\command,,2,"%11%\wordpad.exe /p %1"
> > -HKCR,http\shell\open\command,,2,"winebrowser"
> > -HKCR,https\shell\open\command,,2,"winebrowser"
> > +HKCR,http\shell\open\command,,2,"winebrowser /dde"
> > +HKCR,http\shell\open\ddeexec,,2,"""%1"""
> > +HKCR,http\shell\open\ddeexec\Application,,2,"WineBrowser"
> > +HKCR,http\shell\open\ddeexec\Topic,,2,"WWW_OpenURL"
> > +HKCR,https\shell\open\command,,2,"winebrowser /dde"
> > +HKCR,https\shell\open\ddeexec,,2,"""%1"""
> > +HKCR,https\shell\open\ddeexec\Application,,2,"WineBrowser"
> > +HKCR,https\shell\open\ddeexec\Topic,,2,"WWW_OpenURL"
> 
> Why are you making DDE the default way for the ShellExecute command?
> That's not the case in the default Windows install. Also please make
> sure that the items of the Help menu in Picasa still work after your
> changes, as it was broken several times after attempts to change default
> registry setup or ShellExecute behaviour.
> 

Yes help menu in Picasa works fine for me, tested this. If we can't use 
"winebrowser %1" then DDE _has_ to be the default, as native does not add %1
(see my conformance test in dlls/shell32/tests/shlexec.c, lines 1057 and 1058).

Also on my XP install, DDE _is_ default:

HKCR\http\shell\open\command is '"C:\Program Files\Internet Explorer\iexplore.exe" -nohome'
HKCR\http\shell\open\ddeexec is '"%1",,-1,0,,,,' 
HKCR\http\shell\open\ddeexec\Application is 'IExplore' 
	 (I decided not to use IExplore, as if the user actually
          has IE installed and running URLs would open by default there, instead of with Winebrowser, and I
          wasn't sure this was the behavior we wanted)
HKCR\http\shell\open\ddeexec\Topic is 'WWW_OpenURL'

What is your default? Perhaps it differs between different versions of windows or maybe even
service packs/IE versions? Am I missing something?

Misha



More information about the wine-devel mailing list