widl: Fix the is_array_type function.

Robert Shearman rob at codeweavers.com
Tue Jun 5 15:35:59 CDT 2007


Dan Hipschman wrote:
> On Tue, Jun 05, 2007 at 07:50:42PM +0100, Robert Shearman wrote:
>   
>> Previously, an array of pointers wouldn't be detected by this function.
>> ---
>>  tools/widl/header.h |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> diff --git a/tools/widl/header.h b/tools/widl/header.h
>> index 57ae6b4..2165db7 100644
>> --- a/tools/widl/header.h
>> +++ b/tools/widl/header.h
>> @@ -69,7 +69,7 @@ static inline int is_string_type(const a
>>  static inline int is_array_type(const attr_list_t *attrs, const type_t *type, const array_dims_t *array)
>>  {
>>      return ((last_ptr(type) && !array && is_attr(attrs, ATTR_SIZEIS)) ||
>> -            (!is_ptr(type) && array));
>> +            array);
>>  }
>>  
>>  #endif 
>>     
>
> This and your next patch are in the same area as the one I just sent in
> yesterday.  Actually, my patch completely removes this function.  Can
> you try doing whatever you're working on with my last patch applied and
> see if that fixes your problems?

Ah, I was aware of that patch, but I didn't review it. The trouble is 
that a big chunk of work in my tree will likely conflict with that patch.

>   Generating the format string for
> arrays of pointers is going to required a little more work because
> FIXED_REPEAT, etc. isn't implemented yet.
>   

And this is the chunk of work. I have a patch that implements writing of 
typeformat strings for all embedded pointers.

-- 
Rob Shearman




More information about the wine-devel mailing list