shell32: conformance tests for unicode filenames and fix a bug forfile deletion (try 2)

Nigel Liang ncliang at gmail.com
Fri Jun 8 03:12:25 CDT 2007


On 6/7/07, Dmitry Timoshkov <dmitry at codeweavers.com> wrote:
> "Nigel Liang" <ncliang at gmail.com> wrote:
>
> > +static const WCHAR UNICODE_PATH[] = {'c',':','\\','w',0x00ef,0x00f1,0x00eb,
> > +    't',0x00e8,'s','t','\0','\0'}; /* "c:\winetest" */
>
> The name above is definitely not "c:\winetest", also if you need a double
> termination '\0' state it specifically.
>

Yep, you are right, it is actually "c:\wïñëtèst". I will fix it in the next try.

> > +static int IsWin9x(void)
> > +{
> > +    OSVERSIONINFO winver;
> > +    GetVersionEx(&winver);
> > +    return winver.dwPlatformId==VER_PLATFORM_WIN32_WINDOWS;
> > +}
>
> (GetVersion() & 0x80000000) is much shorter way to detect win9x, but
> if you need to test whether the platform supports unicode that's wrong,
> have a look at other tests how it's done there.
>

I see that the way it is being done in gdi32/tests/font.c is to look
for functions that exist only on Win2k or later, is that the right way
to do it? Or is there another place that I should be looking?

Thanks,
-Nigel



More information about the wine-devel mailing list