Using [GS]etWindowLong{Ptr} in tests
Saulius Krasuckas
saulius2 at ar.fi.lt
Fri Jun 8 15:12:05 CDT 2007
* On Fri, 8 Jun 2007, Alexandre Julliard wrote:
> * Saulius Krasuckas <saulius2 at ar.fi.lt> writes:
> >
> > Ok, so what would you say about a benefit of renaming of
> > SetWindowLongPtr to SetWindowLongPtrA ?
>
> I wouldn't say anything at this point. It's up to you to explain what
> the benefits are,
Well, I already said: there are two names used in one file, both for a
single function. What if I add new test for it? I just don't know which
name to use. What if I use SetWindowLongPtr and SetWindowLongPtrA
interchangibly in my patch? I don't believe it's OK.
> why SetWindowLongPtr and not others,
I am sorry, I didn't stuck upon other fns. I would ask about them too.
> why Dmitry is wrong in his objections, etc.
He isn't wrong neither right. His arguments just didn't persuade me.
More information about the wine-devel
mailing list