[GDI+: 2/5] added Pens implementation, test

Alexandre Julliard julliard at winehq.org
Mon Jun 11 08:00:44 CDT 2007


"Evan Stade" <estade at gmail.com> writes:

> Hi,
>
> Changelog:
> *added pen implementation
> *added just enough memory and startup implementation to support pens
> *defined some types
> *added pen test

You need to send that stuff in smaller chunks, for instance there's no
reason to put startup implementation and pens in the same patch. Also
things like the GpBrush definition should be part of the brush patch
not the pen one. The tests can also be a separate patch.

I'll commit the startup code part of the patch, have a look at this to
see what a minimal patch should look like.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list