Alexandre Julliard : winecfg: Fix potential null pointer access ( spotted by Yaroslav Skorokhodov).

Alexandre Julliard julliard at winehq.org
Tue Jun 12 06:53:56 CDT 2007


Vitaly Lipatov <lav at etersoft.ru> writes:

> В сообщении от 12 июня 2007 Alexandre Julliard написал(a):
> ...
>> @@ -107,7 +107,7 @@ static void update_comboboxes(HWND dialog)
>>      winver = get_reg_key(config_key, keypath(""), "Version", "");
> What wrong with call get_reg_key (,,,NULL) ? Why we need winver as NULL 
> pointer and as empty string?

This way it also handles the case where you have an empty string and
not just a missing entry. Not really fundamental, but since the code
already handles this there's no reason to break it.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list