[PATCH 1/3] gdi32: Set current position properly after ArcTo.

Misha Koshelev mk144210 at bcm.edu
Wed Jun 20 12:02:20 CDT 2007


On Wed, 2007-06-20 at 12:09 +0200, Alexandre Julliard wrote:
> Misha Koshelev <mk144210 at bcm.edu> writes:
> 
> > +        if (!PATH_IsPathOpen(dc->path))
> >          {
> > -            angle = atan2(
> > -                ((yend-ycenter)/height),
> > -                ((xend-xcenter)/width));
> > -            MoveToEx(hdc, GDI_ROUND(xcenter+(cos(angle)*xradius)),
> > -                     GDI_ROUND(ycenter+(sin(angle)*yradius)), NULL);
> > +            if (result && dc->funcs->pMoveTo) result = dc->funcs->pMoveTo(dc->physDev,end.x,end.y);
> 
> It would be cleaner to add a PATH_ArcTo function instead of having
> multiple PATH_IsPathOpen checks in the generic function.
> 

Nevermind. 

I guess what I will have to do is allow addition of arbitrary start
types in PATH_AddArcPart and then add the PT_MOVETO to the current DC
position if pPath->newStroke is true directly in PATH_Arc if lines is
-1.

I'll submit some patches later on.

Misha



More information about the wine-devel mailing list