winmm: Specify the arguments of the function in the function pointer

Alexandre Julliard julliard at winehq.org
Thu Jun 21 08:24:55 CDT 2007


Michael Stefaniuc <mstefani at redhat.de> writes:

> @@ -114,10 +114,10 @@ static	BOOL	MMDRV_GetDescription32(const char* fname, char* buf, int buflen)
>      DWORD	dw;
>      BOOL	ret = FALSE;
>      UINT	u;
> -    FARPROC pGetFileVersionInfoSizeA;
> -    FARPROC pGetFileVersionInfoA;
> -    FARPROC pVerQueryValueA;
> -    HMODULE hmodule = 0;
> +    DWORD       (WINAPI *pGetFileVersionInfoSizeA)(LPCSTR,LPDWORD);
> +    BOOL        (WINAPI *pGetFileVersionInfoA)(LPCSTR,DWORD,DWORD,LPVOID);
> +    BOOL        (WINAPI *pVerQueryValueA)(LPCVOID,LPCSTR,LPVOID*,UINT*);
> +    HMODULE     hmodule = 0;

It may have been done that way because local WINAPI pointers crash on
old versions of gcc. But that whole function should probably be
removed, dumping version info doesn't belong in winmm.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list