[PATCH try2 4/4] gdi32: Call pMoveTo if available when emulating ArcTo/PolylineTo/PolyBezierTo.

Misha Koshelev mk144210 at bcm.edu
Thu Jun 21 23:55:35 CDT 2007


On Thu, 2007-06-21 at 16:11 +0200, Alexandre Julliard wrote:
> Misha Koshelev <mk144210 at bcm.edu> writes:
> 
> > This sends proper position information to the GDI driver when we are emulating these functions.
> 
> I don't think I agree with this one. If the driver needs to update the
> position then it should implement ArcTo etc. since it may need to
> distinguish that from an explicit MoveTo. Or if the generic
> implementation is really good enough in all cases then we shouldn't
> export a driver entry point at all.
> 

Fyi I don't think we can get rid of the driver entry point b/c of the
case of enhmfdrv which needs to write the exact function call that is
made. Our implementation of enhmfdrv currently doesn't implement ArcTo,
and I would maybe implement one, but it looks like right now the
conformance tests for enhance metafiles are todo (our enhanced metafiles
don't match native byte by byte), so I'll have to see.

But in any case I think the function entry point definitely needs to
stay.

Misha



More information about the wine-devel mailing list