[PATCH try2 2/2] winemenubuilder: Wait for application icons to be created instead of adding a RunOnce entry that may never run.

Alexandre Julliard julliard at winehq.org
Wed Jun 27 08:42:08 CDT 2007


Misha Koshelev <mk144210 at bcm.edu> writes:

> Hmm... I was not aware of this (that means that make change.ok in
> dlls/kernel32/tests fails on non-Linux systems?). What happens in these
> other non-Linux systems... does FindFirstChangeNotification return
> INVALID_HANDLE_VALUE or succeed and just never satisfy the wait
> condition?

It will never satisfy the wait. That can happen on older Linux kernels
too, or on network file systems. You can't rely on change
notifications, they are just a hint.

> The good thing about the __wine_make_system_process wait we are also
> waiting for is that it will get satisfied when all user processes have
> closed and create links then as well. This is actually sufficient in
> itself for some installers (Vector NTI), but not others that launch apps
> while installing (iTunes). Perhaps I can add a long timeout to the wait
> to account for these other non-Linux platforms...

A better approach would probably be to simply wait for the parent
process to exit.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list